Benedikt Franke
Benedikt Franke
@zimzat I did follow up on your suggestion to use `SplFixedArray`, seems like a useful optimization. Can you elaborate on what specifically you find concerning? The methods in `SyncPromise` are...
@zimzat I did another round which should hopefully alleviate your concern. Benchmarks look good too, what do you think?
## Memory Benchmark Results Ran memory benchmarks comparing `master` against the optimized implementation using a [benchmark script adapted from @zimzat's test](https://gist.github.com/zimzat/310e9121225ef18640fad2f4ab675ad4#file-test-php). ### Results | Metric | Master | Optimized |...
## Benchmark Results Summary Ran benchmarks comparing this branch against `master` on PHP 8.3.6. ### Key Changes - Promise state changed from strings (`"pending"`, `"fulfilled"`, `"rejected"`) to integers (`0`, `1`,...
Next steps for me: - try this in my real-world projects - try this in nuwave/lighthouse
Lighthouse and a large project of mine work.
Released with https://github.com/webonyx/graphql-php/releases/tag/v15.29.0.