lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

ADD @witohutGlobalScopesDirective and test

Open saeed-rostami opened this issue 1 year ago • 10 comments

add @withoutGlobalScopes directive which works on argument to ignore global scopes that are defined in the model.

type Query { posts ( allPosts (Bool @withoutGlobalScopes (names : ["scheduled"]) ) }

saeed-rostami avatar Jun 29 '24 08:06 saeed-rostami

Hello should I add the directive description in the docs md file?

saeed-rostami avatar Jun 30 '24 08:06 saeed-rostami

Hello should I add the directive description in the docs md file?

Eventually, yeah. Let's make sure it is properly described first.

spawnia avatar Jun 30 '24 09:06 spawnia

Thanks again, new commit pushed ...check the doc file please

saeed-rostami avatar Jul 02 '24 06:07 saeed-rostami

There is a typo in the title, and tests are failing.

spawnia avatar Jul 02 '24 10:07 spawnia

There is a typo in the title, and tests are failing.

Can you give me more details about the test error?

saeed-rostami avatar Jul 03 '24 07:07 saeed-rostami

There is a typo in the title, and tests are failing.

Can you give me more details about the test error?

You can look at the results in https://github.com/nuwave/lighthouse/actions/runs/9746838503.

spawnia avatar Jul 03 '24 08:07 spawnia

Ok..., I pushed another commit...hope will be succeed

saeed-rostami avatar Jul 03 '24 08:07 saeed-rostami

Ok..., I pushed another commit...hope will be succeed

You don't have to hope, you can run the tests locally. See https://github.com/nuwave/lighthouse/blob/master/CONTRIBUTING.md.

Please let me know when every comment has been addressed and CI passes.

spawnia avatar Jul 03 '24 08:07 spawnia

Ok..., I pushed another commit...hope will be succeed

You don't have to hope, you can run the tests locally. See https://github.com/nuwave/lighthouse/blob/master/CONTRIBUTING.md.

Please let me know when every comment has been addressed and CI passes. I'm living in Iran...docker is sanctioned and the internet situation is bad ... but I will try anyway thanks

saeed-rostami avatar Jul 03 '24 08:07 saeed-rostami

Finally, I tested locally and both tests were successful.

saeed-rostami avatar Jul 05 '24 13:07 saeed-rostami

Finally, I tested locally and both tests were successful.

There are still plenty of unresolved discussions. Please address them all.

spawnia avatar Jul 07 '24 10:07 spawnia

Finally, I tested locally and both tests were successful.

There are still plenty of unresolved discussions. Please address them all.

please check them

saeed-rostami avatar Jul 07 '24 13:07 saeed-rostami

NEW COMMIT PUSHED

saeed-rostami avatar Jul 08 '24 09:07 saeed-rostami

NEW COMMIT PUSHED

I am a bit irritated by your use of ALL CAPS.

Anyways, thanks for making the requested changes. I think I failed to communicate how I would like certain things to be done very specifically. The intent of your changes is clear, so I am going to go ahead and make smaller changes, I think that will be more efficient than going back and forth.

spawnia avatar Jul 08 '24 09:07 spawnia