Benedikt Franke

Results 527 comments of Benedikt Franke

There are quite a few places where `new InvalidDataException` occurs. Is your suggestion to attach the entire reponse body to each of them?

`InvalidDataException` actually seems wrong in that place, since it deals with the status code. Let's introduce a new exception type here (not a subtype, just another type). Can you provide...

Thanks @simPod, i released a version that has the new exception with https://github.com/spawnia/sailor/releases/tag/v0.35.0.

I am not planning to work on this myself, but can provide guidance for a pull request. All validation concerns are handled in `src/Validation`. In order to implement this, look...

Yeah, a feature toggle would be great if there is breakage. Allows for a smoother transition to a new major version where we might change the default or remove the...

A similar issue was already reported in https://github.com/barryvdh/laravel-ide-helper/issues/1368.

What are the steps to actually use SQLite testing? Do all tests pass with it?

Does any passed in `__typename` have to be present as a `type` in the schema 100% of the time? If so, we could add a mapping at the schema level...

Consider that without aliases, the "real path" can be ambiguous or have conflicts. ```graphql { foo: bar { qux } baz: bar(arg: 3) { qwak } } ``` I would...

If possible, I would like to see it implemented as a method in order to calculate it lazily. And I would call it `unaliasedPath`, that explains what it is.