Solar Designer
Solar Designer
There's room for optimization here, as we check `ctx->rule` for non-NULL twice on most calls. Also we reset `rules_stacked_after` on every call. This is written as if it actually looped...
Yes, need more review/testing of zero- vs. one-based, especially as it relates to `single.c` storing those numbers (for what use?)
> Why isn't `(!ctx->rule)` enough here? We'd end up going over the rules again, infinitely.
> We'd end up going over the rules again, infinitely. Oh, could use `ctx->done` for that, like the single mode version of this function uses.
> The old code had no such check. The old code returned with `ctx->rule` pointing at the just used rule. The new code returns with it pointing at the next...
We also should not forget to fix "bug we had before, where single mode would log stacked rule number 1 twice".
Thank you for trying to update the package and for reporting this issue @ajakk! Can you please try dropping the `static` keyword from this line: ```c static noinline int lkrg_dummy(int...
@poisonflood Oh, that's unfortunate. I expected removing `static` would help because its addition was made between 0.9.8 and 0.9.9, and @ajakk implied that the issue didn't appear on 0.9.8. But...
It looks like the issue may be exposed by building LKRG with `clang`.
@ajakk Thank you for testing! Are you building LKRG with clang?