Solar Designer

> This PR currently fails our whitespace-errors test: > > ``` > Run git diff-index --check --cached 4b825dc642cb6eb9a060e54bf8d69288fbee4904 > ``` This is still failing. You can run the above `git`...

Hi. Sorry for the lack of progress here. I haven't forgotten, and intend to revisit. Meanwhile, any comments from @ldv-alt would help as well.

Thank you @Zaiba-S! As you noticed, I merged your 3 PRs a few hours ago, with intent to complete my review and testing and apply further changes shortly. I did...

Done for AVX-512. Yet to do for OpenCL. I've been switching to new S-boxes one-by-one, watching code size. It decreased for all but S4, where there was a slight increase...

Also, need to add this to `NEWS` crediting Sovyn Y. - this is definitely newsworthy. Perhaps along with the OpenCL implementation, as I forgot to update `NEWS` in today's commit...

Testing on GTX 1080 with `Driver Version: 418.39 CUDA Version: 10.1`, I get for our old code: ``` ptxas info : 0 bytes gmem ptxas info : Compiling entry function...

There appears to be a regression for LM, register pressure increases a lot. Was: ``` [solar@super run]$ LWS=128 GWS=65536 ./john -te -form=lm-opencl -dev=4 -v=5 initUnicode(UNICODE, RAW/RAW) RAW -> RAW ->...

> There appears to be a regression for LM, register pressure increases a lot. > The first build stays at 168 registers like before, but the second build somehow increases...

I don't know how much of a performance regression it actually was for LM because benchmark results fluctuate between 5xxxM and 7xxxM for both old and new S-boxes. I guess...

Hi @zvonkok! Thank you for bringing this in here. It's an interesting direction, but it's not currently on the roadmap and I see little incentive to plan it. So unless...