Solar Designer

> Heck I should even try to make a universal binary, never tried that. I did for ppc+x86, this is still "supported" in our `Makefile.legacy`. We could update this to...

The referenced hashcat pull request has changed a lot since I posted the original description of this issue. It isn't yet clear what will actually go into hashcat, and thus...

The hashcat PR referenced here got merged 2 weeks ago, and a new hashcat release was made today. So we need to review what actually got into hashcat and adapt...

Thanks @fukc-gihtub and @magnumripper. I don't understand this description of `B`, but anyway I think we should open a separate issue for these additions. This issue is to figure out...

Sure, I understand what's happening and am not surprised. I just think that their decision to remove old runners is silly (but maybe I don't know some underlying reasons) and...

My thinking was to start with what I've been doing in manual testing - running pwqcheck on a large file and confirming the hash of its output isn't unexpectedly changed....

This PR currently fails our whitespace-errors test: ``` Run git diff-index --check --cached 4b825dc642cb6eb9a060e54bf8d69288fbee4904 tests/test-pwqcheck-length.sh:14: trailing whitespace. + tests/test-pwqcheck-length.sh:18: trailing whitespace. + tests/test-pwqcheck-length.sh:22: trailing whitespace. + tests/test-pwqcheck-multi.sh:13: trailing whitespace. +...

> Are you suggesting that we implement this approach in addition to the individual tests I proposed? In general, yes. In this same PR, no. > If so, For storing...

The color output could be undesired when redirected to a build log file. I suggest to use color only when outputting to a tty, which I think you can test...

Please also add your copyright statements and references to `LICENSE` as source code comments near the start of your scripts, similarly to how we have this in existing source files.