Solar Designer

Results 148 issues of Solar Designer

Our `keepass2john.c` has: ```c uint32_t FileVersion32 = 0x00040000; uint32_t FileVersion32_4 = 0x00040000; // from KeePass 2.36 sources // We currently support database formats up to KDBX v3.x. KDBX 4.x is...

enhancement
new format

I don't know if this is do-able - are VeraCrypt volumes distinguishable from TrueCrypt when we don't know the password yet? If they are, then we should implement such detection...

enhancement

`pem_common_plug.c: pem_decrypt()` decrypts the entire ciphertext, then uses a padding check for early-reject. It could instead start by decrypting only the last block (using the previous block as IV), do...

enhancement

As seen in warnings in the screenshot in #5109, the `__swab*` macros in our `eapmd5tojohn.c` may clash with same-named macros in the Linux kernel's headers. Somehow this does not happen...

portability

It looks like running `nt-opencl` with mask on Vega 64 overflows some math leading to incorrect c/s and C/s figures: ``` $ ./john -form=nt-opencl -mask='?a' -min-len=6 -max-len=8 -dev=1,4,5 -fork=3 pw...

bug

Running with `--rules-skip-nop` makes `john` jump over the `:` rule, which is commonly the first in a rule set, and this results in slightly incorrect progress percentage (starts at 0.07%...

bug

As seen in #5058, a new user might not figure out where to look for the cracked password in `--show` output. One way to address this is to highlight the...

enhancement

As discussed in https://github.com/openwall/john/issues/5004#issuecomment-1019310089: Shouldn't the current code have rejected a repeated rule like the below (when running `-ru=jumbo`)? ```shell $ fgrep 'c Az"111"' sim3.log 0:00:02:49 - Rule #923: '-c...

bug

We currently support words-first (with `--rules`) or rules-first (with `--rules-stack`) or a mix of these two with two rule sets one applied on top of another. That's kind of up...

enhancement
new cracking mode

`malloc` accepts a `size_t` argument, our own wrappers like `mem_alloc` and others in `memory.[ch]` do as well. On 32-bit platforms, `size_t` is typically 32-bit as well. However, we have calls...

bug
portability
maintenance/cleanup