Solar Designer

Results 1104 comments of Solar Designer

Thank you very much @cpuchainorg! Regarding the example page, I think it'd help if you start printing the hash encodings returned by yescrypt(). Since we currently don't have an API...

@cpuchainorg Thank you! This seems to work mostly correctly, but the `hex` input isn't working right (not yet implemented? the setting seems ignored). Also, it'd help to be able to...

@cpuchainorg Thanks. Yes, it was a think-o on my part that ability to specify salt in base64 would have helped for this - it doesn't, because indeed crypt()'s encoding is...

Thanks, Adam! How did you find this? Are you now auditing LKRG in some way?

Two CI jobs are failing, here's one of them: ``` [ 65.846291] BUG: unable to handle page fault for address: ffffffffffffffff [ 65.850473] #PF: supervisor read access in kernel mode...

The other is similar: ``` [ 90.075865] BUG: unable to handle page fault for address: ffffffffffffffff [ 90.079916] #PF: supervisor read access in kernel mode [ 90.080314] #PF: error_code(0x0000) -...

> The same problem is issued without this PR. Moreover, the problem is only visible when LKRG is loaded during booting process. Well, but we had this same test run...

> It is some type of race as you can see here only 1 instance failed. Yes. I re-ran those two jobs after your previous comment, and only 1 of...

I wonder if it's maybe some backport that's been made recently into kernels (or gcc or something else?) on those older versions of Ubuntu, which are LTS and still maintained.

> maybe we can tune CI to enable DEBUG build with more verbose logs to see what's going on on CI You can try that in your fork of the...