Šarūnas Nejus comments

Results 229 comments of


                                            Šarūnas Nejus

Fix changelog workflow

https://github.com/beetbox/beets/pull/5305 let's try our luck one more time

Fix most types in beets.util.init

Weird stuff: as you've seen my change made that single test fail on Windows, see [this build](https://github.com/beetbox/beets/actions/runs/8966693983/job/24622737166) [22e2a3c](https://github.com/beetbox/beets/pull/5223/commits/22e2a3cd2c0842205cfb6b4be1a2f10adb704cda) for example ``` FAILED test/plugins/test_web.py::WebPluginTest::test_get_item_file - Attribut... ===== 1 failed, 1639 passed,...

Fix most types in beets.util.init

@wisp3rwind as you suggested I used `bytes` wherever possible and resolved the typing issues without having to use `AnyStr` everywhere. I'd be happy to move this forward if you have...

Fix most types in beets.util.init

> Otherwise, it seems that there have been some changes around `syspath` and the `bytes` vs `str` vs `Path` question. I don't think I'm qualified to comment on the correctness...

Fix most types in beets.util.init

> > > Otherwise, it seems that there have been some changes around `syspath` and the `bytes` vs `str` vs `Path` question. I don't think I'm qualified to comment on...

Fix most types in beets.util.init

Is there anything else that needs addressing here @wisp3rwind?

Fix most types in beets.util.init

Cool, will merge it in once you've approved it 🙂

Test aura

@Serene-Arc could you have a glance at this one? It should be an easy one!

Test aura

Going to merge this one first. #5266 removes `setup.py` altogether and already has `pytest-flask`, so I'll rebase the PR to resolve the conflict :)