Šarūnas Nejus

Have also added a test for the retry behaviour. Pretty sure it's ready now, merging!

Oops, apologies! I'm currently working on migrating the rest of plugins away from `musicbrainzngs` so I will take care of this :)

I think I'm missing something... Is this condition so complex it needs testing? https://github.com/beetbox/beets/pull/6117#discussion_r2454370978

Remember the reason I did the investigation behind that comment: after your adjustment, I could not any more understand what this code does. The test does not help. On the...

@semohr As far as I remember this was initially implemented using decorator pattern. Why did you switch to the proxy pattern? I'm most likely missing context, but, I think, the...

> One challenge with using a decorator is that it needs to be applied to each plugin individually Can we not use the `metadata_plugins.candidates`, `metadata_plugins.item_candidates` etc for this?

I'm thinking something in these lines indeed ```py def _safe_call( plugin: MetadataSourcePlugin, method_name: str, *args, **kwargs, ): """Safely call a plugin method, catching and logging exceptions.""" try: method = getattr(plugin,...

> This is mostly how i had it before. This does not catch the errors during the yield and handling this properly requires a bit more work. Also typing is...

> Just had a short look and this will absolutly break beets-flask downstream. We use the mappings dict quite a bit... Can we move this change in particular to a...

> Renaming does not really help me here 😆 I'm not sure that I understand - `AlbumMatch.mapping` is now present like it was before. I just introduce a new property...