Šarūnas Nejus

Is there anything missing here @semohr?

@semohr @henry-oberholtzer @JOJ0 would be happy to have your eyes over this as I think this is a significant piece of work making autotagging somewhat simpler (hopefully!).

I've noticed this issue too. The PR that introduced the behaviour you mentioned: #5821. I'm indeed leaning towards making this an OR query. > if e.g. there's missing tracks, the...

We've got an open PR #6052 where we drop `musicbrainzngs` and query MB API directly, so we will have the flexibility to form the query we want. I'm thinking about...

I just stumbled upon this function in the same module: ```py def _make_attribute_table(self, flex_table: str): """Create a table and associated index for flexible attributes for the given entity (if they...

See this blog post for more context regarding flexible attributes: https://beets.io/blog/flexattr.html. Certain implementation details can potentially be optimised, but the core concept is going to stay, I think. > How...

I'm largely fine with the changes but since this affects one of the key pieces of the code base I think we'd benefit from hearing what @wisp3rwind thinks about it...

I tested this locally and discovered a performance issue with the current implementation. It queries the database separately for each existing index on the table (N+1 problem): ```sql $ BEETS_DEBUG=1...

I appreciate the clarification on the intent. A few thoughts: **On the migration system design:** I understand this mirrors the table migration approach, and I can see the code does...