Šarūnas Nejus

Results 229 comments of Šarūnas Nejus

Hi @wisp3rwind, thanks for your response! See below for the failed tests: ``` FAILED test/test_limit.py::LimitPluginTest::test_prefix - AssertionError: 10 != 5 FAILED test/test_limit.py::LimitPluginTest::test_prefix_when_correctly_ordered - AssertionError: 10 != 5 FAILED test/test_limit.py::LimitPluginTest::test_prefix_when_incorrectly_ordred -...

@arsaboo it should indeed work. You may as well try checking out this PR and attempt to, say, list tracks using your filter: `beet ls plex_ratingkey:xyz`. I'd be happy to...

I've got something similar implemented in the `beetcamp` plugin, where most of the fields can be excluded. See the [readme](https://github.com/snejus/beetcamp) or the [implementation](https://github.com/snejus/beetcamp/blob/master/beetsplug/bandcamp/_metaguru.py#L587) ```yaml bandcamp: ... exclude_extra_fields: [] ... ```

Running import without exclusions: ![image](https://user-images.githubusercontent.com/16212750/143325854-5d18a832-6dfa-426e-9760-82c248048068.png) Running import with ```yaml exclude_extra_fields: - genre - style - albumartist - comments - title - albumstatus ``` ![image](https://user-images.githubusercontent.com/16212750/143326009-1e8393fd-c82a-45f1-abb8-7b413ac1fbfc.png) The configuration option should actually be...

I added a `print(model_cls._table, query)` call to the `Database._fetch` method in `beets.dbcore.db` to see what's going on: ``` $ beet list -a path::djstingray items MatchQuery('id', 0, True) albums AndQuery([RegexpQuery('path', re.compile('djstingray'),...

I've just opened a pull request which contains an update on query composition, which (I think) does not cause a big change in the overall architecture.

Thanks for a reminder, will try reviving it in the coming days.

I've been intending to come back to this but have been too busy recently. This PR crosses my mind every weekend and I know I will be coming back to...

> Did you check whether this refactoring still passes type checking (i.e. mypy)? It's happy! ![image](https://github.com/beetbox/beets/assets/16212750/1586c775-9c81-444d-9f09-d7a8f22cf13e) mypy runs live in my editor as I code where it's allowed to control...

@wisp3rwind you can see that I replaced `memoryview` with `bytes` in `PlaylistQuery` to query BLOB column `Item.path`. Is there a reason we're using `BLOB_TYPE = memoryview` instead of `bytes`? I...