Fix changelog workflow

[snejus]

Use pull_request_target event for the changelog update reminder

See https://github.com/marketplace/actions/comment-pull-request#permissions for more details.

Additionally, refactor the workflow into a more canonical form utilising the tj-actions/changed-files GitHub action.

[wisp3rwind]

So, I'm definitely not an expert on Github actions at all. At a superficial glance, this looks reasonable.

Is pulling in the tj-actions/changed-files action necessary to make this work independent of the source of the PR? Or would the old git diff solution also work?

[snejus]

So, I'm definitely not an expert on Github actions at all. At a superficial glance, this looks reasonable.

Is pulling in the tj-actions/changed-files action necessary to make this work independent of the source of the PR? Or would the old git diff solution also work?

Nope - it's not necessary. That's just an extra nice to have

[Serene-Arc]

I'm good to merge this if you're happy @snejus

[snejus]

@Serene-Arc go ahead!

[bal-e]

I think this broke the changelog check. For example, from a fresh PR (#5303): https://github.com/beetbox/beets/actions/runs/9516482690:

Invalid workflow file: .github/workflows/changelog_reminder.yaml#L19 You have an error in your yaml syntax on line 19

I think YAML is unhappy with **.py, maybe it just needs to be double-quoted?

[snejus]

Oh no, let me try and fix it!

[snejus]

https://github.com/beetbox/beets/pull/5305 let's try our luck one more time