Romain Tartière

Results 243 comments of Romain Tartière

> Absolutely and always interested in FreeBSD ;-) Unfortunately, I still can not find the time for unit tests. :tada: I do not think we need to worry about tests...

Ah. I feel like I encountered this at some point, but I was not able to reproduce my failing test after refactoring so assumed I added a missing dependency somewhere…...

Hi @siebrand > It's unknown to me how to try and get more attention for this ticket... The most efficient way to move on is probably to open a PR...

This regexp is barely readable :unamused:. PRs are always welcome, however, workaround for a problematic case should be avoided (e.g. setting `strict_version_checking=false` because otherwise compilation fail). In any case, the...

I trend to agree: validating version numbers is a PITA and unless this is utterly needed, should be avoided IMHO.

:+1: for honoring SemVer: currently we actively reject expected to be compatible versions. Also if a security issue is found in node 14, it would be fixed as 14.20.1 (now...

> Also if a security issue is found in node 14, it would be fixed as 14.20.1 My bad, 14.20.0 already fix three medium severity issues and two high severity...

#2101 was merged and update nodejs to 14.20.0 so this Issue title is not true anymore. I suggest to update it to better match the discussion, something like "[BUG] Not...

#2101 was merged and update nodejs to 14.20.0, but the point of this PR/issue #2088 remains. I would suggest clarifying this by updating this Issue and PR subject to something...

> Would you mind rebasing @smortex, im going to add it to a priority list to get picked up on our next community day. Poke @hackdna as they own the...