Romain Tartière

:+1: I am not 100% sure but AFAICR, building libfreefare master branch against the latest libnfc release does not work. So maybe we should also release a new libnfc version...

Hum, this was changed in 42f9457d9f193c3e55893c75f60b980f88326bf5 which I committed probably after somebody gave me a diff (I do not have the DESFire EV1 datasheet neither, and that's a fairly large...

Information is available [on page 41 of this PDF](https://web.archive.org/web/20201115030854/https://marvin.blogreen.org/~romain/nfc/MF3ICD81%20-%20MIFARE%20DESFire%20-%20Functional%20specification%20-%20Rev.%203.5%20-%2028%20November%202008.pdf):  Would you like to crate a PR that add a function (e.g. `mifare_desfire_get_key_settings()`) which also return the key type?

The [older specification](https://web.archive.org/web/20201115030818/https://marvin.blogreen.org/~romain/nfc/Mifare%20DESFire%20Product%20Specification.pdf) has nothing about these bits, so I think the best would be to add a new function that makes this information available through an extra paramter, and...

Ah, this also include changes form #118. Maybe better keep each topic in a dedicated branch, and if you need both changes for working use a custom local branch where...

I added you as a collaborator, unless I am wrong, I believe you can approve Pull Requests and merge approved Pull Requests. I guess #118 can be merged quickly, then...

I would prefer we do not loose _how_ the CRC is computed because it's done in a unusual way (and the documentation is so inaccurate I was lucky to be...

No objection. Please tell me if your current privileges do not allow you to do this.

> While reading the source I also came along that malloc is not checked for errors. Should have been fixed in f6c7f76

@dodgambit, thanks for this detailed report! I understand you are talking about this: https://github.com/nfc-tools/libfreefare/blob/9d88c18833450a91b97fc6ac91c1d983ed3a8681/libfreefare/mifare_desfire_crypto.c#L435-L437 And indeed, this was added in 8975c60de784e93a1cdcfe0f8698a0c6166ca593 with no much details… I hoped that the commit...