Romain Tartière

@bastelfreak please see https://github.com/puppetlabs/puppetlabs-puppetdb/compare/pdk...smortex:pdk?expand=1 I am able to run tests locally with some annoyance but I think these are related to Vagrant (since I an working on my FreeBSD laptop):...

I would not expect a puppetdb module to adjust firewall rules for the puppetserver…  Firewall configuration is somewhat site specific, managing firewall rules related to a service from the module...

LGTM! On the top of my head, if some variable substitution (i.e. `CACHE` in your message above) is allowed maybe it can be useful to interpolate other configuration settings. A...

Generally speaking, the voxpupuli modules support what upstream support (according to https://www.mongodb.com/support-policy/lifecycles this seems to currently be 4.2, 4.4 and 5.0 for MongoDB) or when installing system packages what the...

Make sense :+1:. Can do this the same way for all modules, a quick check show that some bits are missing in at least: ```sh-session romain@zappy puppet-collectd % grep -r...

From your working directory: ``` git rebase -i origin/master # Interactively rewrite history ``` This will bring your editor. Keep the first line unchanged, and replace `pick` with `squash` for...

Hey! Please submit each change proposal in a different PR :-). The easiest way is to create *feature branches*: one new branch per feature / bug fix. When a branch...

So yeah, this fails with Puppet 6 because the module try to install `zabbixapi` which depends on `http` → `addressable` → `public_suffix` in Puppet's ruby gems and the latest version...

CI was recently fixed. Can you please rebase your changes on top of the main branch? From your working directory: ``` git fetch origin # Download the latest code we...

I just merged #643 which include it. Let's re-trigger a build