puppet-elasticsearch icon indicating copy to clipboard operation
puppet-elasticsearch copied to clipboard

Add FreeBSD platform

Open olevole opened this issue 8 years ago • 6 comments

Pull request acceptance prerequisites:

  • [x] Signed the CLA (if not already signed)
  • [ ] Rebased/up-to-date with base branch
  • [ ] Tests pass
  • [ ] Updated CHANGELOG.md with patch notes (if necessary)
  • [ ] Updated CONTRIBUTORS (if attribution is requested)

olevole avatar Apr 03 '17 14:04 olevole

Hi there,

Firstly, thank you for taking the time to contribute, and apologies for the radio silence from Elastic on this PR.

I'm going to be working on this module over the next few weeks, with an ultimate aim of updating the module to support the elasticsearch 7.x and simplifying the module to make it easier to use.

I'll be reviewing all the open issues and PRs over the next few days, and will merge or provide feedback where appropriate.

So please hang in there whilst we give this module some TLC.

Thanks again.

fatmcgav avatar Feb 04 '20 13:02 fatmcgav

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine avatar Feb 04 '20 13:02 elasticmachine

It makes sense!

@olevole this has been lagging for a tremendous amount of time, and the module was recently adopted by voxpupuli and gained a refresh! Would you be interested to apply these changes on top of the current master branch?

I think you could also add FreeBSD in metadata.json :wink:

smortex avatar Dec 08 '21 21:12 smortex

It makes sense!

@olevole this has been lagging for a tremendous amount of time, and the module was recently adopted by voxpupuli and gained a refresh! Would you be interested to apply these changes on top of the current master branch?

I think you could also add FreeBSD in metadata.json wink

Absolutely and always interested in FreeBSD ;-) Unfortunately, I still can not find the time for unit tests.

olevole avatar Dec 09 '21 07:12 olevole

Absolutely and always interested in FreeBSD ;-) Unfortunately, I still can not find the time for unit tests.

:tada:

I do not think we need to worry about tests at this point. Maybe one day we will be able to run acceptance tests on FreeBSD but at the moment the unit tests are probably fine.

Due to the massive update to have the code working with recent puppet / ruby, rebasing is likely to be a pain. Maybe an easier strategy is to git a fresh 'master', apply the changes there (probably with some adjustments) and push the changes to update this PR:

git fetch origin               # Get the latest code from GitHub
git reset --hard origin/master # Loose all changes and put the branch on master
# re-apply the changes
git add .  && git commit
git push -f                    # -f needed: we re-wrote history

smortex avatar Dec 09 '21 19:12 smortex

Dear @olevole, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jun 21 '22 20:06 vox-pupuli-tasks[bot]