Fix error when creating roles on AWS RDS

[hackdna]

More details: https://tickets.puppetlabs.com/browse/MODULES-5068

[puppet-community-rangefinder[bot]]

postgresql::server::role is a type

Breaking changes to this file WILL impact these 22 modules (exact match):

• nicopaez-dockerserver
• braiins-zabbix
• jjulien-trac
• landcareresearch-pidservice
• braiins-sentry
• nnutter-testdb
• deric-pgprobackup
• Aethylred-gitlab
• nicopaez-alfred
• nicopaez-triage
• lwo-dataverse
• hetzner-roundcube
• maestrodev-maestro
• it2ndq-barman
• npwalker-pe_external_postgresql
• adullact-demarchessimplifiees
• deric-barman
• puppetfinland-puppetmaster
• landcareresearch-ckan
• groupbuddies-gb
• blackknight36-bacula
• puppetlabs-puppetdb

Breaking changes to this file MAY impact these 6 modules (near match):

• Firebladee-moodle
• tedivm-hieratic
• Aethylred-puppetdashboard
• puppetfinland-patchwork
• echoes-wrappers
• soli-wrappers

This module is declared in 70 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

All committers have signed the CLA.

[github-actions[bot]]

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

[pmcmaw]

Removing needs attention label, apologies we haven't got around to triaging and reviewing this PR.

[pmcmaw]

Would you mind rebasing @smortex, im going to add it to a priority list to get picked up on our next community day.

[hackdna]

No worries. Looking forward to getting this 5 year old issue finally addressed.

[smortex]

Would you mind rebasing @smortex, im going to add it to a priority list to get picked up on our next community day.

Poke @hackdna as they own the PR.

[GSPatton]

hey @hackdna, we're looking into this. Could you rebase and resolve any conflicts? Thanks!

[hackdna]

Great, thanks for looking into this. I think I've resolved the merge conflict.

[GSPatton]

Hey @hackdna . pg_roles is also a deprecated view, so replacing instances of one deprecated view with another is not a satisfactory fix unfortunately. I advise you research other potential fixes and create another PR when you've found something and we'll happily take a look.

Thank you for your contributions!

[hackdna]

Hey @GSPatton, I've used pg_roles because it's already used extensively in role.pp. Also, another "legacy" view pg_shadow was used in a recently merged PR: https://github.com/puppetlabs/puppetlabs-postgresql/pull/1347/files. How is this case different?