David Smith

> ... that we'd trigger the workflow in the `smithdc1/django-asv` repo ... Yes -- That's how I had it in my head to start with too. However, we ran into...

There's a long thread (dating back to 2018) on the govuk-design-system. They show some user research which is interesting and my takeaway is that it is hard. The final comment...

While working on another patch for the admin I checked this patch as well.  This patch will introduce issues with the admin as the input will get an `aria-labelledby`...

> we fix this in advance? 🤔 Ah yes, I didn't think of that. 👍

Let's take https://github.com/django/django/pull/15241 first.

Please test locally instead of running the tests via Jenkins. 👍

There are some notes in the contributing guide, this page here is most relevant. https://docs.djangoproject.com/en/3.1/internals/contributing/writing-code/unit-tests/#quickstart In summary - the quick start guide gets you setup (install requirements) and shows how...

A couple of initial thoughts are: - Does it make sense to have `aria-invalid` alone? Isn't this just saying 'hey there's an error here". That's not very helpful without an...

I found https://www.w3.org/WAI/WCAG21/working-examples/aria-invalid-data-format/ as a worked example quite helpful. It shows `aria-invalid` being used when there is no `aria-describedby` (and visa versa). I therefore I _think_ option 1 could for...

If there is consensus this change is acceptable then there are a few similar cases we should consider. The most obvious being `CsrfTokenNode`