David Smith

Results 109 comments of David Smith

I'm wondering if we need three ways to do the same thing. If we have a preference should we be slightly more opinionated? Could we even go as far as...

Hi @clintonb I've tried to replicate this issue. I've written the following test; however, as it passes I must not be understanding your issue correctly. Are you in a position...

Hi @peterthomassen apologies, it's unlikely I'm going to get time to look at this again any time soon.

I know there is divided opinion on it. For me I like the consistency, as I often forget hanging indentation or a trailing comma, which then takes time to both...

Just to add to the sharing / embedding point above. There's a fair amount of Django snippets which get shared on Twitter, is there anything we could do here? See...

Hey @deepakdinesh1123 Thank you for the contributions here. Maybe we should be adding these to the ASV repo as the primary way we wish for benchmarks to be run going...

> I wouldn't have to write them twice. Super :-)

How about something like this? ```python class TestNullBooleanField(TestCase): @pytest.mark.filterwarnings('ignore::rest_framework.RemovedInDRF314Warning') def test_allow_null(self): msg = '`allow_null` is not a valid option.' with self.assertRaisesMessage(AssertionError, msg): serializers.NullBooleanField(allow_null=False) def test_deprecation_warning(self): msg = "The `NullBooleanField` is...

Hi All Appreciate it's been a while and therefore don't expect anyone to recall this. I tried to write tests for this patch, but I must be miss-understanding this change....

Closing as per @thibaudcolas's comment