django icon indicating copy to clipboard operation
django copied to clipboard

Refs #32819 -- Added aria-describedby for help_text.

Open smithdc1 opened this issue 2 years ago • 4 comments

Ticket 32819

This adds aria-describedby functionality for help_text. We'll still need to think about errors but that seems a much more complex based on prior work. Would it be ok to approach this ticket in stages?

smithdc1 avatar Dec 27 '21 21:12 smithdc1

While working on another patch for the admin I checked this patch as well.

image

This patch will introduce issues with the admin as the input will get an aria-labelledby but the help text doesn't have the id.

@felixxm -- shall I work on this as part of this PR (as a separate commit) or would you want to take it as a separate change?

smithdc1 avatar Dec 31 '21 08:12 smithdc1

This patch will introduce issues with the admin as the input will get an aria-labelledby but the help text doesn't have the id.

Can we fix this in advance? :thinking:

felixxm avatar Dec 31 '21 08:12 felixxm

we fix this in advance? 🤔

Ah yes, I didn't think of that. 👍

smithdc1 avatar Dec 31 '21 08:12 smithdc1

Let's take https://github.com/django/django/pull/15241 first.

smithdc1 avatar Apr 07 '22 06:04 smithdc1

Updated in #16185.

felixxm avatar Oct 17 '22 18:10 felixxm