David Smith

Results 109 comments of David Smith

Thank you Natalia. One other thing I thought about is having it available as a pre-commit hook. It seems that a separate repository would be required though and that feels...

Thank you for your thoughts -- A couple of responses from me. I'm happy to add these to the DEP if that would be helpful. > If Django does any...

Hi @camuthig Help with pushing this forward would be very much appreciated. Do you have thoughts on what steps should be taken to progress this?

@sarahboyce -- Circling back around to this one. Is it worth moving the first commit to a separate PR and reviewing/merging that first? (probably need some tweaks to the release...

I think this is getting close -- but I need to have another look over the docs. Let me know if you want to pull out the change adding the...

> Agreed ⭐ I think we'll get this into 5.2 🤞 Let's try. Maybe we can ask @thibaudcolas for an early Christmas gift and have his review too. 😀

Rebased... To do: - [x] Review docs - [x] Add test as per https://github.com/django/django/pull/17520#discussion_r1883688400 - [x] Is this now fixed rather than refs? Anything else?

> Is this now fixed rather than refs? I reviewed the ticket and think this can be called 'fixed'. > I would like the tests to cover a broader set...

@sarahboyce -- I had a go at editing the docs. This is ready for review now.

Super. Any comments on docs would be very much welcomed. I've now got the same feeling I have at work when I'm checking a presentation of numbers in it. I...