smcameron

Results 399 comments of smcameron

> if they could be adapted to support receiving an array, we could pass the whole player_ids array and avoid having loops everywhere, is that possible? player_ids[] is a global,...

> The debug prints were already there, I only moved them along. I did not test it. Ah, you're right about that. > Only problem left is zarkons will attack...

One problem I see: ``` -- find the player and move him where we want him to start. player_ids = get_player_ship_ids(); if (player_ids[1]) then for i, player_id in ipairs(player_ids) do...

Hmm, trying it with 3 ships just now, it seems to get stuck saying "incoming transmission from icarus station" repeatedly. Well, I was running on a single machine, so all...

Ah, it's because your patch adds this: ``` -- check to see if the space vaccine has been acquired and if so send in the zarkons function check_for_zarkon_attack() print("checking for...

It's every 15 seconds. So when you get the vaccine, the zarkons will attack, on average, 7.5 seconds later (maybe sooner, but no later than 15 seconds after). From an...

Yeah, maybe. But I don't want to give the players enough time to warp anywhere before disabling the warp drive.

Alright, I have a patch to make the zarkons attack the correct player. If I may add your Signed-off-by, then I'll go ahead and commit it. ``` Author: Stephen M....

To be clear, I am asking you for permission to add your signed-off-by to your patch, or you can send me another patch with your signed-off-by already in it. --...