PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

new tutorial: basics of parcel-model ODE system (with a readable minimalistic SciPy+pint solution)

Open bhiogade opened this issue 1 year ago • 3 comments

bhiogade avatar Mar 15 '24 17:03 bhiogade

closing and reopening to trigger rebuild against current main (where the updated devops_tests will detect the rendering problem with notebooks caused by buggy PyCharm version)

slayoo avatar Mar 18 '24 07:03 slayoo

@bhiogade, thanks! Here are some comments:

  • [x] there seem to be a clash between saturated_vaporpressure and saturated_vapor_pressure
  • [x] let's remove all unused variables (pylint will help)
  • [ ] total_multiplicity is the same as TOTAL_AEROSOL_NUMBER - worth removing for now for clarity?
  • [x] it would be beneficial to separate physical constants (e.g., g, R, etc) from model parameters (e.g., updraft)

slayoo avatar Mar 18 '24 08:03 slayoo

BTW

  • [x] it seems that we do not really need to import numpy here - worth removing to keep it minimalistic as per the original idea - it should also help to make the code more readable (no more np.asarray, etc); for defining output steps, we could replace np.linspace(...) with nt = 40; dt_out = 5 * si.s; t=[(i*dt_out).to(si.s).magnitude for i in range(0, nt)] and then provide GUI sliders for nt and dt_out

slayoo avatar Mar 18 '24 09:03 slayoo