Slava Krutelyov

switch pixelLess iteration to use CKF instead of mkFit

4

Discussion in PPD Aug 4 https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit. This PR makes the switch and...

mkFit updates aiming to improve pixelLess iteration and related

5

Motivated by observed inefficiency in the pixelLess iteration track building for low-pt displaced tracks, several features/bugs were fixed and improvements to the algorithm were added: - consistently sort seeds in...

fixup reading histograms in TrackTimingTable in trackingPlots

4

I came across an error in parsing the timing results using `makeTrackValidationPlots.py` ``` File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_0_pre4/src/Validation/RecoTrack/python/plotting/trackingPlots.py", line 1837, in create cpuValues = self._getValues(tdirectory, _time_per_event_cpu) File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_0_pre4/src/Validation/RecoTrack/python/plotting/trackingPlots.py", line 1813, in _getValues h...

switch pixelLess iteration to use CKF instead of mkFit

10

Discussion in PPD Aug 4 https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit. This PR makes the switch and...

expand coverage for creation of simGtExtUnprefireable in miniAOD

9

the initial version integrated in #31985 is making the simGtExtUnprefireable product available only in run2_miniAOD_UL setup. todo: to figure out the full set of input workflows where `tcdsDigis:tcdsRecord` is available...

restrict usePF2PAT to load modules already on existing sequences or tasks

4

currently usePF2PAT loads all modules accessible in `patSequences_cff` to `patAlgoToolsTask` (+pre/post-fix) https://github.com/cms-sw/cmssw/blob/96b6501ba97b688cbf3559f7322c67976da337de/PhysicsTools/PatAlgos/python/tools/pfTools.py#L407-L421 this may become impossible to maintain if some modules can run only with a specific era or process...

make addpackage check the current dir is inside of CMSSW_BASE

3

I sometimes forget to cmsenv before running git, after switching from another release area. Current behavior of cms git tools (cms-addpkg) will make changes to the old release area, making...

Documentation/comment code style rules

4

https://cmsdoxygen.web.cern.ch/cmsdoxygen/ is apparently still maintained/supported What is the general feeling to still keep supporting the doxygen style comments in the code? I frequently recall to ask for it in the...

phase2 PV sorting is not using HGCAL inputs (only the barrel and HF contribute to ak4CaloJetsForTrk) will be needed for jetCore as well

30

this is a follow up to #31743 https://github.com/cms-sw/cmssw/issues/31743#issuecomment-711253630 CaloJets (`ak4CaloJetsForTrk` made out of `caloTowerForTrk`) are used in PV sorting and none of the HGCAL inputs are used in the phase-2...

[RFC] cleanup of frequent shadow warnings

26

While compiling with `-Wshadow` for a test I decided to cleanup some of the more frequent cases exposed mainly by being present in interface/. Perhaps this can be a step...