cmssw switch pixelLess iteration to use CKF instead of mkFit

Discussion in PPD Aug 4 https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit.

This PR makes the switch and removes Run3_ckfPixelLessStep, which is now identical to Run3 (I checked this using the run3 wf 11834.0 expanded config for step3).

@cms-sw/tracking-pog-l2

Aug 04 '22 14:08 slava77

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38967/31421

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #38880, #38760, #38702, #33532
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): #33532, #38749

Aug 04 '22 14:08 cmsbuild

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/PyReleaseValidation (pdmv, upgrade)
Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. @fabiocos, @VourMa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @lecriste, @trtomei, @mmusich, @mtosi, @beaucero, @dgulhan this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Aug 04 '22 14:08 cmsbuild

@cmsbuild please test

Aug 04 '22 15:08 slava77

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/26642/summary.html COMMIT: dda3f63703cf5af7b67de9324066c4552dd8def9 CMSSW: CMSSW_12_5_X_2022-08-04-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38967/26642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 19186 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3691510
DQMHistoTests: Total failures: 30994
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 3660492
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.008 KiB( 50 files compared)
DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: found differences in 3 / 50 workflows

Aug 04 '22 19:08 cmsbuild

@cmsbuild please test

Aug 12 '22 11:08 srimanob

@slava77 I have not followed up closely. I assume this PR is ready to go, right? I just call the test again as the last one is a week ago.

Aug 12 '22 11:08 srimanob

@slava77 I have not followed up closely. I assume this PR is ready to go, right? I just call the test again as the last one is a week ago.

I do not expect any functional modifications in this PR.

The only pending item was a formal go-ahead from PPD/Validation that this is good to go for the default. But that part is perhaps on the ORP part of the sign off.

Aug 12 '22 12:08 slava77

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/26780/summary.html COMMIT: dda3f63703cf5af7b67de9324066c4552dd8def9 CMSSW: CMSSW_12_5_X_2022-08-12-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38967/26780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 19335 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 30990
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3661463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: found differences in 3 / 50 workflows

Aug 12 '22 15:08 cmsbuild

+Upgrade

From the upgrade side, this PR follows the agreement on switching pixelless iteration to use CKF instead of mkFit.

Aug 13 '22 01:08 srimanob

+pdmv

Aug 13 '22 09:08 kskovpen

+1

As agreed at the Aug 16 ORP meeting

Aug 16 '22 15:08 perrotta

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Aug 16 '22 15:08 cmsbuild

type tracking

Nov 30 '23 20:11 slava77

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/36218/summary.html COMMIT: dda3f63703cf5af7b67de9324066c4552dd8def9 CMSSW: CMSSW_14_0_X_2023-11-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38967/36218/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 164 lines from the logs
Reco comparison results: 28 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 1201
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3368809
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

Nov 30 '23 23:11 cmsbuild