cms-sw
restrict usePF2PAT to load modules already on existing sequences or tasks
currently usePF2PAT loads all modules accessible in patSequences_cff to patAlgoToolsTask (+pre/post-fix)
https://github.com/cms-sw/cmssw/blob/96b6501ba97b688cbf3559f7322c67976da337de/PhysicsTools/PatAlgos/python/tools/pfTools.py#L407-L421
this may become impossible to maintain if some modules can run only with a specific era or process modifier
One solution could be to restrict the module picked up in https://github.com/cms-sw/cmssw/blob/96b6501ba97b688cbf3559f7322c67976da337de/PhysicsTools/PatAlgos/python/tools/helpers.py#L61-L90 to just the ones already attached to sequences or tasks; perhaps traversing patDefaultSequence is enough with NodeVisitor
https://mattermost.web.cern.ch/cms-o-and-c/pl/pi94usrjcp8n5mqzd33d5zmkdc
New categories assigned: xpog,reconstruction
@slava77,@fgolf,@mariadalfonso,@gouskos,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks
A new Issue was created by @slava77 Slava Krutelyov.
@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
why didn't we move this forward @slava77 ?
I don't recall the details. It could be that reco was waiting for xpog to follow up.
why didn't we move this forward @slava77 ?
I don't recall the details. It could be that reco was waiting for xpog to follow up.
apparently initially the context was related to the PAT unit tests https://github.com/cms-sw/cmssw/pull/33928#issuecomment-868786345