cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

fixup reading histograms in TrackTimingTable in trackingPlots

Open slava77 opened this issue 3 years ago • 4 comments

I came across an error in parsing the timing results using makeTrackValidationPlots.py

  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_0_pre4/src/Validation/RecoTrack/python/plotting/trackingPlots.py", line 1837, in create
    cpuValues = self._getValues(tdirectory, _time_per_event_cpu)
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_0_pre4/src/Validation/RecoTrack/python/plotting/trackingPlots.py", line 1813, in _getValues
    h = tdirectory.Get(histo)
TypeError: bad argument type for built-in operation

the proposed fix lets the job run to completion

@elusian

slava77 avatar Aug 14 '22 17:08 slava77

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39054/31556

  • This PR adds an extra 32KB to repository

cmsbuild avatar Aug 14 '22 17:08 cmsbuild

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Validation/RecoTrack (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @wmtford, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 14 '22 17:08 cmsbuild

@cmsbuild please test

slava77 avatar Aug 14 '22 18:08 slava77

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad7f2/26806/summary.html COMMIT: 551b05ed8e39c7837445f38b91133705d0c222d5 CMSSW: CMSSW_12_5_X_2022-08-14-0000/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39054/26806/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @fwyzard cms-sw/cmssw#39016
  • @civanch cms-sw/cmssw#39052
  • @fwyzard cms-sw/cmssw#39047

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad7f2/26806/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad7f2/26806/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692452
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 14 '22 21:08 cmsbuild

+1

emanueleusai avatar Aug 16 '22 06:08 emanueleusai

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Aug 16 '22 06:08 cmsbuild

+1

qliphy avatar Aug 16 '22 08:08 qliphy