Stefanos Kornilios Mitsis Poiitidis

Results 336 comments of Stefanos Kornilios Mitsis Poiitidis

Note: As a general design goal, it would be nice to move more (most?) of the guest signal handling to `syscalls` from the `jit dispatcher`

Bug: `sigaction::sa_mask`, and `sigaction`/`signal` self blocking is not working in the current implementation at all.

`GuestSigAction`: GuestSAMask doesn't match kernel structure padding. Kernels are configured by default with only 64 signals, so this should be ok, but they could be configured with up to 1024...

Note from https://man7.org/linux/man-pages/man2/sigaction.2.html ``` Undocumented Before the introduction of SA_SIGINFO, it was also possible to get some additional information about the signal. This was done by providing an sa_handler signal...

Note: There are several flags of `sigaction` that we may not support correctly right now (`SA_EXPOSE_TAGBITS`, `SA_RESETHAND`, `SA_RESTORER`, `SA_NODEFER`)

Note: pselect6 (and possibly others) take the signal mask as a parameter, which might have complications around host -> guest signal handover.

Issue: Our internal signals that shouldn't be blocked (SIGRT31, any others?) will pass a guest-sent, guest-blocked signal to the guest, instead of holding it. We need to at least defer...

Issue: glibc uses internally signals 32, 33 (and possibly 34, only? in LinuxThreads which is no longer used). Guest glibc and host glibc handling might cause issues there. We need...

Also, the Offsets can be stored inline in the cache, instead of in the relocation