Stefanos Kornilios Mitsis Poiitidis
Stefanos Kornilios Mitsis Poiitidis
(Closing this as there is an ongoing powergrab by @Sonicadvance1, I will migrate my work to https://github.com/skmp/fex-emu-ng.git)
~For the thunked xcb + unthunked libX11 case, https://xcb.freedesktop.org/MixingCalls/, XGetXCBConnection & XOpenDisplay might offer a solution there.~ It was an issue with the hostcall support, after all.
They are the same code, the mode of operation is detected by whenever X11 is thunked or not. FGL only exists as a json alias.
Only GLX is affected, and sadly, due to how libGL works on linux, GLX is also in libGL, not only libGLX.
So to keep separate impls, we'd have to also keep two libGLs with is easily 100x GLX in entrypoints
(The original PR /did/ have two libs, this is the rewrite that merged them for less code)
> I'm fine with more code to keep the implementations separate, or if you want to save some code duplication add some GL_Common folder or something then have each implementation...
> As a general remark, I'll quote my comment from #1734: > > > As mentioned in other channels, what I need to review your ThunkLibs PRs is better separation...
After today's discussion, - This will not affect the non-FGL path in general, and users should take note that things may break with FGL. - Apart from getting thunks up-and-running...
> I see nothing has moved on this still. Yes, as I've been blocked doing noop work on other tickets, and of course this now has to be needlessly rebased,...