Stefanos Kornilios Mitsis Poiitidis
Stefanos Kornilios Mitsis Poiitidis
I was debugging this yesterday, the issue is that the socket loop runs after the session is deleted (m_ending is true). I'll see if i can fix and pr today.
m_ending is set in [RTMPSession::~RTMPSession()](https://github.com/jgh-/VideoCore/blob/52ded8ae3dcbbec5d6f00a0717fbfa7d1408b34c/rtmp/RTMPSession.cpp#L86) I think that changing while((m_streamSession->status() & kStreamStatusReadBufferHasBytes) && !stop2) to while(!m_ending && m_streamSession && (m_streamSession->status() & kStreamStatusReadBufferHasBytes) && !stop2) in [line 335](https://github.com/jgh-/VideoCore/blob/52ded8ae3dcbbec5d6f00a0717fbfa7d1408b34c/rtmp/RTMPSession.cpp#L335) Should fix this...
@Sonicadvance1 this one does need to be heavily re-worked, pending on coordination with @neobrain
Following up on today's discussion Main rationale around the PR is - Export only symbols defined on the interface files from the guest thunk, and hide all others to avoid...
> > Export only symbols defined on the interface files from the guest thunk, and hide all others to avoid exposing thunk lib internals to the guest. > > Sounds...
> > As the interface files also generate exports (as per the above feature), we need some way to avoid that (explicit guest-only export, or internal that doesn't need to...
> > No, because this happens in the relocation phase, not during dlsym. Think of it as, host GL library doesn't return &glGetString, it returns an internal, unnamed symbol. >...
In general, under posix rules, any time you use a "visible" symbol, you're creating a relocation entry and not linking directly. Eg. Assuming following this code gets compiled to `question.elf`...
> > guest dynamic linker > > Ah, I was mixing up a couple of things there, but yes of course we can't actually override the `dlopen` flags for the...
@neobrain now that we have reached clarity on the exact issues, can we get an agreement on how to solve them?