Pieter Wuille
Pieter Wuille
I think the goal should be that there is as little "unexpected inconsistency" between builds. Our release (guix) binaries are created with -O2, and most of our testing is with...
See also #32337.
@achow101 Hmm, what would happen if `addmultisigaddress` for descriptor wallets just imports the computed descriptor as it does now (with RPC arguments that must be existing addresses or hex pubkeys)?...
I'm interested in seeing benchmarks of this on various systems, especially high-end/modern ones (as their performance is likely most predictive of what future hardware will be like). ``` ./build_dev_mode/bin/bench_bitcoin --filter="Linearize.*Example.*"...
@ismaelsadeeq Not an apples-to-apples comparison I'm afraid, because the benchmark cases are changed in this PR too. Can you run the `LinearizeBoundedExample?` benchmarks too?
@instagibbs @ismaelsadeeq @gmaxwell FWIW, I didn't include apples-to-apples comparison because the large-scale comparison [benchmarks](https://delvingbitcoin.org/t/how-to-linearize-your-cluster/303/73) I did (especially, [this one](https://delvingbitcoin.org/uploads/default/original/2X/2/22ad16f71db37fcb8cadb8a8f73c4acfd3def203.png)) were just overwhelmingly in favor of SFL over the existing one....
Thanks for all the benchmarks, here are some graphs created from them to show their relative performance: (code & data to generate them is [here](https://gist.github.com/sipa/f002a7e552fedabd5d727eb4a55624f0))
If people are interested in a much larger scale comparison between the old and the new algorithm, checkout https://github.com/sipa/bitcoin/commits/bench_sfl_css, build its `bin/bench_bitcoin`, and: ``` wget https://bitcoin.sipa.be/clusters/clusters.tgz tar -xzf clusters.tgz for...
I've created a repo for benchmark data, and added my results plus @l0rinc's: https://github.com/sipa/lin-benches/tree/main/data. Also, is this with 32-bit or 64-bit userspace?
Rebased on top of #30605.