Pieter Wuille

Results 554 comments of Pieter Wuille

Happy to add a bech32 reference implementation for Java if someone contributes one. I have no plans to write one myself.

Hmm, is it desirable to restrict the code to bc/bcrt/tb? I don't think the other reference code does that.

Yeah, I think I'd prefer removing that requirement.

I think you shouldn't use segwit_addr.c directly as it's specific for segwit addresses. Feel free to copy the convert_bits function though; it's trivial.

Hmm, would there be a way to generate these on the fly? The size of the QR code will depend on the address type.

Thinking more about it, it's a bit more complicated as you can't just convert a segwit address to an old-style address. I'll add an extra box for encoding, which lets...

@romanornr Right, but I'll do the work of generating addresses first - something the current JS code does not support.

Thanks a lot for doing this, and my apologies for the slow responses. Two comments: * I prefer to have "reference implementations" - things that are easily copy-pastable (and possibly...

Concept ACK, but beeds rebase, sorry for the late response.

The list of DNS seeds is now out of date again :)