Pieter Wuille
Pieter Wuille
@paplorinc Huh, this PR shouldn't affect IBD speed at all. EDIT: is this an IBD test from random peers? That will have way too much variance to conclude anything from...
@paplorinc Yes, it is an optimization, but only affects the `scantxoutset` and `gettxoutsetinfo` RPCs. Normal synchronization should be unaffected.
This looks like a LevelDB corruption inside the txindex index. Does `-reindex` wipe those? If not, that would explain why a reindex doesn't fix the situation.
@maflcko Ah yes, it is the version here that had a corruption in the txindex: https://bitcoin.stackexchange.com/q/123999/208
ACK 9b7023d31a3ec95f66b45f0ecb47e79762d74854
I'm not convinced about the approach here: it's leaking a SipHash implementation detail (the way the initial v0..v3 values are computed) into a higher layer (util/hasher.h). I would suggest to...
Code review ACK 656da514c5a3ee4d376b9b60f57451d3e4b6aec7
I don't think we should have any commits which are known to not compile on a reasonable system. You'll need re-ACKs anyway for the PR, I don't think there is...