Pieter Wuille
Pieter Wuille
> Keeping BIPs under the bitcoin.org bitcoin.org is an independent website, whose source code is on https://github.com/bitcoin-dot-org/Bitcoin.org. It is operated by different people, and unrelated to the bitcoin org on...
> Than I misinterpreted what was meant by "By moving one or both repos out of the bitcoin github org, this conflict can be resolved." Glad that we are intending...
ACK e80e4c6ff91e27d7d40f099a2d7942c29085234c
It may be hard to do that perfectly; for example, if a recent CPFP occurred that bumped a low-fee old parent up high enough to make it into the template,...
Imagine the following state: ```mermaid graph BT g["genesis"]; f["fork_point"]; a["ActiveTip()"]; b["pindexBestKnownBlock"]; l["pindexLastCommonBlock"]; p["P"]; f-->g; a-->f; l-->p; b-->p; p-->f; ``` In this situation, I think we want to update `pindexLastCommonBlock` to...
@mzumsande Agree that sounds sufficiently unlikely to optimize for (and sufficiently expensive to intentionally cause). Code review ACK on the logic change, but I want to have a look at...
Concept ACK, but disagree with the approach of the first commit. I don't think it tests anything useful: * If it wanted to test the exact behavior of the skip-height...
My point is that these two properties, regardless of how they are accomplished, are the interesting ones to test. * Your test achieves the first, but only approximately, and is...
@optout21 Cool, approach ACK. You'll need to make sure both commits compile, though.
There is an annoying conflict in design goals here. On the one hand, it's copying code to mimick the traversal algorithm. When copying code, you should not assume that the...