Pieter Wuille

Results 777 comments of Pieter Wuille

utACK 7b6fe5a2196d53a3024dfe7f11b316a50acc3cb7 The code changes make sense, I think, given the fact that the block index failed flags are generally kept consistent already, apart from some edge cases around `invalidateblock`....

utACK 33381ea530ad79ac1e04c37f5707e93d3e0509ca

ACK 175740991e0081c35f471cd7f1ad067e3e1f978f

My advice would be to never ever look at the contents of ZMQ notifications, but just see them as notifications that new information may be available, so you should go...

Alternatively, could we just add a `secp256k1_` prefix to our test names?

@l0rinc @philmb3487 I think we shouldn't conflate these issues. From the linked #28552 issue, it appears that there is an actual demonstrable corruption that happens specifically due to exFAT on...

@real-or-random Thanks for the fixes. I've removed my earlier attempt from the commit history. If this works, I'll extract the non-ECDH-related parts from this PR and submit them separately.

@real-or-random Yeah, I think both of your commits should be submitted as a separate PR. Perhaps the benchmark change here should also (as ECDH benchmarking without including pubkey decoding is...