simon-id

Results 74 comments of simon-id

@CarlesDD can't approve because it's my own PR but LGTM

Note to remember later: we've previously decided to keep plugins out of the appsec code and with the other tracing plugins. Let's consider this question again.

@vdpjulien a member from dd-trace-js needs to take over your PR to recreate it and pass the CI, i'll forward it

@tlhunter would this be under the responsibility of your team ?

@oursodon I pinged again the relevant people, don't hesitate to ask again if you don't get a reply

I see there is activity on this PR, FYI I'm planning on reviewing it and adding the appsec changes next week

I don't think there is any roadblock from ASM's perspective, as we backport everything anyway. We'd just have to doublecheck our CI testing the right stuff in the right versions....

Ah this rings a bell, and it looks like the CI is failing so maybe that's the reason we never updated it ? it's worth a few retries