dd-trace-js
dd-trace-js copied to clipboard
refactor: move remote_config code to the root of dd-trace
What does this PR do?
Move the folder remote_config on level up from packages/dd-trace/src/appsec to packages/dd-trace/src.
Motivation
The Remote Configuration code was first introduced by the appsec team. Now that more and more teams are using it, it makes sense to move it to a shared location in the root of the dd-trace package.
Overall package size
Self size: 8.77 MB Deduped: 94.97 MB No deduping: 95.49 MB
Dependency sizes
| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe
Benchmarks
Benchmark execution time: 2025-02-25 13:19:45
Comparing candidate commit 74302437568cbec9567b9f35a25a896dc1ec954d in PR branch watson/refactor-remote-config with baseline commit 96bb84ab2fee2da5e4d11af38464412557809dcf in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.
- #4475
👈 (View in Graphite) master
This stack of pull requests is managed by Graphite. Learn more about stacking.
I see there is activity on this PR, FYI I'm planning on reviewing it and adding the appsec changes next week
I'm just playing around with Graphite, so this PR got rebased in the process
Codecov Report
Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
Project coverage is 80.27%. Comparing base (
96bb84a) to head (7430243). Report is 13 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| packages/dd-trace/src/remote_config/index.js | 60.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #4475 +/- ##
==========================================
- Coverage 80.94% 80.27% -0.67%
==========================================
Files 488 489 +1
Lines 21844 21860 +16
==========================================
- Hits 17681 17548 -133
- Misses 4163 4312 +149
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Datadog Report
Branch report: watson/refactor-remote-config
Commit report: d3adcc6
Test service: dd-trace-js-integration-tests
:white_check_mark: 0 Failed, 671 Passed, 0 Skipped, 11m 50.46s Total Time
/merge --method squash
View all feedbacks in Devflow UI.
2025-02-25 13:22:46 UTC :information_source: Start processing command /merge --method squash
2025-02-25 13:22:54 UTC :information_source: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2025-02-25 14:28:42 UTC :warning: MergeQueue: This merge request was unqueued
[email protected] unqueued this merge request
/remove
View all feedbacks in Devflow UI.
2025-02-25 14:28:33 UTC :information_source: Start processing command /remove
2025-02-25 14:28:36 UTC :information_source: Devflow: /remove