simon-id

Results 74 comments of simon-id

If I disable the remote config requests, the test passes. Instead of disabling remote config (not currently possible), could we just fix the damn test instead ? :sweat_smile:

Good question, I'm not so sure anymore, because a customer recently wanted to use setUser() but without ASM enabled, which works already. Thus making me doubt about moving this to...

FYI @mcollina I'm planning on opening a follow up PR after this one is merged to introduce an "aborting" mechanism to the DC events. I'd like to have your web...

Please do not delete. We still haven't decided that integrity checks must be done in the library, but if it happens one day I want to use this PR.

Yeah I'll close it for now since we went with the AbortController() route. But let's not delete the branch

@cbeauchesne the last one in the list https://github.com/DataDog/system-tests/blob/b7914f96243cb92158daaf4c8f93a5c829818585/tests/appsec/api_security/test_schemas.py#L257 I have no idea how to fix it :/ We can't test that it's "doing something" before because it's tested in a...

>There is nothing in telemetry that tells the feature is implemented, but deactivated ? I'm guessing if it's implemented, it should be sent in the env config telemetry payload, but...

@targos the point of this exception mecanism is that I think it requires the least amount of effort on both sides of the channel (publisher and subscriber). If we start...

@Flarna If I'd reimplement it without the subsequent subscriber interruption, and instead throw after the loop, would you be +1 on it ?

+1 on this then ? ```js const dc = require('diagnostics_channel'); const channel = dc.channel('test'); // subscriber channel.subscribe((message, name, abortController) => { abortController.abort(); }); // publisher const ac = new AbortController();...