dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

add experimental tracing using a native event collector

Open rochdev opened this issue 1 year ago • 4 comments

What does this PR do?

Add experimental tracing using a native event collector that stores and processes traces outside of the application.

Motivation

This was previously just a proof-of-concept. The goal of this PR is to have at last something on the main branch with proper CI tests so that we stay compatible with the use of events.

Additional Notes

rochdev avatar Apr 20 '24 00:04 rochdev

Overall package size

Self size: 6.73 MB Deduped: 61.99 MB No deduping: 62.27 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Apr 20 '24 00:04 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-05-10 20:16:51

Comparing candidate commit 0ce54176099891c795599ccffee85d545ca3a4df in PR branch collector-beta with baseline commit 52da415e4748e6cc821bff53d5f4e99b820ab4f7 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-156.073MB; -89.875MB] or [-16.340%; -9.410%]

pr-commenter[bot] avatar Apr 20 '24 01:04 pr-commenter[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.19%. Comparing base (5278b1c) to head (12d68ac). Report is 4 commits behind head on master.

:exclamation: Current head 12d68ac differs from pull request most recent head c6e9cf4

Please upload reports for the commit c6e9cf4 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4250       +/-   ##
===========================================
- Coverage   80.42%   45.19%   -35.24%     
===========================================
  Files           3       89       +86     
  Lines         373     2518     +2145     
  Branches       33       33               
===========================================
+ Hits          300     1138      +838     
- Misses         73     1380     +1307     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 20 '24 01:04 codecov[bot]

comments closed, LGTM :+1:

simon-id avatar May 03 '24 07:05 simon-id

I believe @bengl is currently working on something similar. Since this contains a lot of conflicts and would need significant rework as such, I am going to close this for now.

Please reopen if you continue working on it while exchanging with @bengl to coordinate work.

BridgeAR avatar Nov 05 '25 13:11 BridgeAR