simon-id
simon-id
You just rm -rf yarn.lock and node_modules than ran `yarn` again right ?
Code LGTM now, but haven't had time to fully review the tests. still I found some problems
You got some system tests failures for API Security scenario, is it just the old tests that we should disable now ?
Code and tests LGTM, but let's resolve that CI failure
So I can approve the change to the comments, but enabling that test parametric tests is outside my jurisdiction. Either you make a separate PR or you find whoever owns...
ok LGTM logic and structure wise, some nits left with the static field and the oneliner string but not blocking. The CI probably needs a good rebase since fastify is...
I found a way to only trigger a job when the target branch changes: https://github.com/DataDog/system-tests/pull/3894 Now I need to find a way to trigger the tests when that happens
So after discussing with Romain, we concluded that it's only possible to restart a CI with either a GitHub App, or a personal token/ See the doc: https://docs.github.com/en/rest/actions/workflow-runs#re-run-a-workflow
I don't think so, the problem still persists, it's jut more complicated than I thought. Ultimately it's not that complicated, but I can't invest time into it just yet. Maybe...
I've reviewed all 344 files in the previous PR, I don't think i have the strength to do it again :/