Silvano Cerza
Silvano Cerza
I think this is going to break integration tests if merged. They're not going to run in this PR since it comes from your fork and env vars won't be...
Oh cool, nice to see this change. I remember trying it in the past and it wasn't working. I'll approve and merge this as soon as you sign the CLA....
I'm a bit unsure about this change to be fair. I understand the need obviously, though we'd need to change also the `filter_documents()` signature to reflect this. The retrievers too...
I don't see why not to be fair, I'm not against this at all. Everything you wrote makes totally sense in my opinion.
Are you going to handle the implementation of this? 👀
Cool! @AnushreeBannadabhavi feel free to open a PR. :)
This is not feasible. All Document Stores and Components must be serialisable to JSON, in turn all their inputs must be serialisable too. If we pass the Weaviate Client in...
I know it's not a destructor but it's called when the garbage collection runs for that object. If written properly it can safely close an existing connection. So in my...
End to end tests are failing cause Mermaid failed returning an image. We can ignore the error, the important thing is that the tests started in this case, if they...
> v14.0 is the latest stable version distributed via debian and we recently updated from 8 to 14 - I think we can stay on 14 for a few years?...