Silvano Cerza

@alex-stoica composition is a good approach in my opinion. 👍

I'm really unsure about this. 🤔 This would also be a breaking change too, not easy to handle either. I'd have to think how we could follow the deprecation policy...

One could already work around this writing something like this: ``` from jinja2 import Environment, meta from haystack.components.builders import PromptBuilder prompt_template = """ Given these documents, answer the question. Documents:...

@FloRul PR from forks can't have access to repository secrets. Those tests should be skipped if the necessary secrets are not found, see [this as an example](https://github.com/deepset-ai/haystack-core-integrations/blob/7cd71f17a3f86a22f74e85db2825f993c597e5b8/integrations/anthropic/tests/test_chat_generator.py#L165-L168).

Why do we need a new converse generator? Isn't it akin to a chat generator that we already have? Shouldn't we update that? It seems like all the abstractions added...

> That is a fair point, the thing with the current bedrock chat is that it relies on adpaters, would it be more logic to consider converse its own adapter...

We already have a standard and that is the `ChatMessage`. Adding all the classes from `utils.py` goes against that. This Component will be extremely hard to use in any existing...

Some additional context. As of now the `FileTypeRouter` doesn't give the users an explicit way to pass additional metadata to converters that receive the routed sources. The `FileTypeRouter` is also...

@alperkaya can you please sign the CLA? Otherwise we can't merge this. :)

This is still not working as expected, I strongly suggest you copy the implementation from core.