haystack-core-integrations icon indicating copy to clipboard operation
haystack-core-integrations copied to clipboard

align tests and docs on NVIDIA_API_KEY (instead of NVIDIA_CATALOG_API_KEY)

Open mattf opened this issue 1 year ago • 4 comments

README.md says Note: integration tests will be skipped unless the env var NVIDIA_API_KEY is set.

with this MR, the statement is now true for all cases.

mattf avatar May 13 '24 14:05 mattf

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 13 '24 14:05 CLAassistant

I think this is going to break integration tests if merged. They're not going to run in this PR since it comes from your fork and env vars won't be set.

The different env var is necessary since we're testing different services that need different API keys. This is the only way to differentiate between them as of now.

Best thing would be to update the README.md to reflect the requirement.

silvanocerza avatar May 14 '24 13:05 silvanocerza

The different env var is necessary since we're testing different services that need different API keys.

the same api key should work for integrate.api.nvidia.com, ai.api.nvidia.com and api.nvcf.nvidia.com

mattf avatar May 14 '24 14:05 mattf

Oh cool, nice to see this change. I remember trying it in the past and it wasn't working.

I'll approve and merge this as soon as you sign the CLA. 👍

silvanocerza avatar May 15 '24 12:05 silvanocerza

lgtm! Thanks @mattf

dglogo avatar Jun 04 '24 17:06 dglogo