haystack-core-integrations
haystack-core-integrations copied to clipboard
align tests and docs on NVIDIA_API_KEY (instead of NVIDIA_CATALOG_API_KEY)
README.md says Note: integration tests will be skipped unless the env var NVIDIA_API_KEY is set.
with this MR, the statement is now true for all cases.
I think this is going to break integration tests if merged. They're not going to run in this PR since it comes from your fork and env vars won't be set.
The different env var is necessary since we're testing different services that need different API keys. This is the only way to differentiate between them as of now.
Best thing would be to update the README.md to reflect the requirement.
The different env var is necessary since we're testing different services that need different API keys.
the same api key should work for integrate.api.nvidia.com, ai.api.nvidia.com and api.nvcf.nvidia.com
Oh cool, nice to see this change. I remember trying it in the past and it wasn't working.
I'll approve and merge this as soon as you sign the CLA. 👍
lgtm! Thanks @mattf