Silvano Cerza comments

Results 111 comments of


                                            Silvano Cerza

feat: add converter based on pdfminer

Also I suggest rebasing or merging `main` in your branch to bring PR #7215 in as I recently changed which checks are required to merge.

feat: add converter based on pdfminer

Didn't notice at all we were missing tests, this causes coverage to go down a bit. Could you add some? 👀

Fix: virtualFile.Read returns EOF with valid data

@GeertJohan is there any chance this will be merged?

Instructions for using the source code?

Some more documentation would be great, I'd love to customize which sets are used instead of default models.

test: Group up Pipeline unit tests in a single class

Part of #7611

JSONDecodeError when _convert_weaviate_result_to_document()

Hey, nice catch, can you please open a PR with the fix? Thanks!

`Table_QA` gives error when querying on the table

@sjrl can you take a look at this? Thanks!

can't pass an object parameter to pipeline.run()

@faaany I'm thinking about an alternative solution to your problem that wouldn't require this change. I'm not sure whether it would work though. I'm taking into consideration #5697 too. My...

can't pass an object parameter to pipeline.run()

Hey @faaany, any news on this? I'm curious to know if you managed to make it work. 👀

Automate testing of code in docstrings

Putting this back in the backlog after some discussion. We thought it would be simpler to add testing of docstrings snippets but is not. We'd have to change how we...