Silvano Cerza

That only happens cause you have write permissions in the repo. PRs coming from forks of first time contributors won't trigger workflows automatically. If we have this kind of concerns...

> [Later](https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#approving-workflow-runs-on-a-pull-request-from-a-public-fork) it also mentions the following, which indicates that the incoming code is what is run: I think we should give this a try. I admit I might be...

I just gave it a try. I was wrong and adding a `pull_request` trigger on a workflow in a PR from a fork indeed triggers that version. I also changed...

@bogdankostic made me rightly notice that secrets are not passed to forks. This is from the repos Action's Secret Settings.  And the `GITHUB_TOKEN` can't have write permissions on `pull_request`...

> Another question I have rn is updating a prompt. I noticed we don't fetch the prompt again if the prompt is cached but is there a way or can...

I do agree with @julian-risch. `test_eval_data_split_word` is testing too much. I didn't look too deeply into it but at a first sight I think it could be split into at...

@hsm207 any news on this?

Closing as this has become stale. Also as stated in https://github.com/deepset-ai/haystack/issues/5348#issuecomment-1639748767 we suggested creating a separate repo and package for this document store.

I do agree with @sjrl here, no need for a new proposal to add a `FilterRetriever`. Also I think it can be generic enough to work with every Document Store....

+1 on this, I was thinking about it too. It's quite frustrating having to specify the component name each time.