haystack icon indicating copy to clipboard operation
haystack copied to clipboard

feat: Add TairDocumentStore

Open dongqqcom opened this issue 2 years ago • 2 comments

Related Issues

  • feat #5348

Proposed Changes:

Addition of a document store using a Tair vector DB (requested in https://github.com/deepset-ai/haystack/issues/5348) in haystack/document_stores/tairvector.py, documents are stored in Tair.

How did you test it?

  • All interfaces of TairDocumentStore have passed the integration tests in test/document_stores/test_tair.py.
  • Unit tests will be added later.

Notes for the reviewer

  • Proposal file: proposals/text/0000-tair-documentstore.md
  • Interfaces: haystack/document_stores/tairvector.py
  • tests: test/document_stores/test_tair.py
  • filter convert: haystack/document_stores/filter_utils.py

Checklist

dongqqcom avatar Jul 14 '23 02:07 dongqqcom

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: dongqqcom
:x: 谭志东


谭志东 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 14 '23 02:07 CLAassistant

I'm the committer 谭志东, and I have not idea how to sign the CLA. Because it shows that: "谭志东 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. ". How could I link this account to 谭志东? 截屏2023-07-14 11 26 11

ghost avatar Jul 14 '23 03:07 ghost

This proposal is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 14 '23 01:08 github-actions[bot]

你好,我已收到你的邮件,会尽快给你回复。

dongqqcom avatar Aug 14 '23 01:08 dongqqcom

This proposal is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 14 '23 01:09 github-actions[bot]

Closing as this has become stale.

Also as stated in https://github.com/deepset-ai/haystack/issues/5348#issuecomment-1639748767 we suggested creating a separate repo and package for this document store.

silvanocerza avatar Sep 14 '23 08:09 silvanocerza