silabs-robin

Another comment: The naming scheme of whatever signals will be in this decoder, should preferably have a clear link to what the signal is and does. For instance, among the...

I have two comments. Firstly: Here is the decoder https://github.com/openhwgroup/core-v-verif/tree/cv32e40s/dev/lib/isa_decoder . Let's merge it to master and close this task.

Secondly, about naming schemes. It is important because the nuances of decoding etc has caused many isacov bugs. (I have expounded on that several times in the past.) Here is...

I'm not sure if/how this relates to https://github.com/openhwgroup/core-v-verif/issues/2147

Seems this is not fixed yet: It is still volatile, with a todo, and temporarily commenting that out gives iss mismatch. 

From what I can tell, the `iff` only sets a qualifying condition to decide when the coverpoint can be sampled. Similar to how `iff` works for bins. So the coverpoint...

The CP in question: https://github.com/openhwgroup/core-v-verif/blob/master/lib/uvm_agents/uvma_isacov/cov/uvma_isacov_cov_model.sv#L977C4-L977C21 The macro in question: https://github.com/openhwgroup/core-v-verif/blob/master/lib/uvm_agents/uvma_isacov/uvma_isacov_macros.sv#L48C12-L48C12 I think the only way to remove the coverpoint might be to use the `with` syntax that was discussed previously....

> could you test it to confirm that with works in that case I couldn't get it to work. (Not sure why, because the LRM grammar seems to say it...

I didn't manage to add `with` expressions to the wildcard bins, because Xcelium got an error saying it was not ok to do so. (Compile time error.) So then I...

> can't we use option.weight = iff_exp in the macros, that way we're sure that does not count @AyoubJalali Yeah, maybe this. I have not tried it.