silabs-robin

I like your proposal. Typo in _"Interface Interfaces or Types"_? Should be _"Interface Instances or Types"_ or for example _"Interface Types and Instances"_? I like the idea of `_st` for...

Maybe also other signals like `dbg`. E.g.: ``` assert property ( rvfi_valid && rvfi_custom.dbg // Fetched as D-mode |-> rvfi_custom.prot[2:1] == 2'b 11 // Fetched as M-mode ); ```

Other discussions: * https://github.com/openhwgroup/core-v-verif/pull/1377 * https://github.com/openhwgroup/core-v-verif/pull/1554

Hi @AyoubJalali. I think you are right indeed. This looks like a copy-paste bug, potentially. C_J and C_JAL does not use "rd", and the "imm_is_signed" should be connected like you...

> I'm with the idea of removing default values Removing defaults would be nice if it could catch errors such as the one we just saw. However, as I look...

> if i'm not wrong, there is more of this copy-paste bug That might be the case. But, if you are fixing these, please keep in mind to double check...

Hello folks. Good catch Ayoub. That's sharp. > cp_rs1_toggle & cp_rs1_value in c.mv & c.add instructions, but these instructions don't use rs1 For `c.mv` you are right that it doesn't...

_(The inference is "lumped > dumped")_

Nice catch. It is a bug indeed. For example, `c.swsp` has a 6-bit immediate, but the quoted code is using `8` because there are 2 implicit zero-bits, and your are...

Hi. I had to investigate a bit because I don't remember what all these things mean (and we weren't clever enough in the past to add descriptive names or comments)....