Shane F. Carr

Results 2307 comments of Shane F. Carr

> My preference would be to just drop the extensions: `English (Myanmar)` not `English (Myanmar [Burma])` or `English (Myanmar (Burma))`. So I definitely favor the addition of menu core/extension values...

If we consider the contents of the parenthetical to be "optional", another approach could be to include the parenthetical when formatting a region display name, but drop it when formatting...

We discussed this in CLDR Design WG and an alternative approach was preferred. #5240

Also, reviewing the Parley thread, I don't think they _should be_ using these new constructors? One of the reasons they want to use `icu_segmenter` is _because_ it supports non-rule-based segmentation....

Would you mind listing the new APIs added by this PR? I think it is the `new_for_non_complex_scripts` constructors and some `default` fns on options structs that already implemented the `Default`...

I remember at some point I had a RataDie limit that was i64 / 256 or something, in order to give "plenty" of room for transient calculations to use more...

I'd be fine making the limit RD-based instead of year-based. +/- 1e8 RD? (the smallest power of 10 that is greater than the Temporal limit) Each calendar is required to...

My post above focuses on `try_from_fields` (and `try_new_from_codes` which is a wrapper over `try_from_fields`). To address the other constructors (CC @robertbastian): - `from_rata_die` is infallible. This suggests that RataDie's constructors...

Seeking consensus on the following: - `Date` is defined to be any date between two specific RataDies, `MIN` and `MAX`. - All fallible functions in `icu_calendar` that return a `Date`...

I want the bounds to be big enough to handle known users and not much bigger than that. Temporal is the known user with the largest range. It appears #7219...